Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dataset): fix multi typed array detection flaw #19035

Merged
merged 1 commit into from
Aug 29, 2023
Merged

fix(dataset): fix multi typed array detection flaw #19035

merged 1 commit into from
Aug 29, 2023

Conversation

linghaoSu
Copy link
Member

@linghaoSu linghaoSu commented Aug 23, 2023 •
edited
Loading

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

fix source formate detect error when dataset's source is multi typed array.

Fixed issues

Details

Before After
desc when dataset's source is multi array, and fist item is not a normal array, will treat sourceFormat as SOURCE_FORMAT_OBJECT_ROWS, actual is SOURCE_FORMAT_ARRAY_ROWS Add typedArray check when dataset's source is an array.
screenshot image image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Aug 23, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@github-actions
Copy link
Contributor

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19035@db20365

@Ovilia
Copy link
Contributor

Ovilia commented Aug 29, 2023

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19035@db20365

Updated with demo: link

@Ovilia Ovilia merged commit bb1e18c into apache:master Aug 29, 2023
@echarts-bot
Copy link

echarts-bot bot commented Aug 29, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia added this to the 5.5.0 milestone Aug 29, 2023
@plainheart plainheart changed the title fix(source): fix multi typed array detect error fix(dataset): fix multi typed array detect error Jan 15, 2024
@plainheart plainheart changed the title fix(dataset): fix multi typed array detect error fix(dataset): fix multi typed array detection flaw Jan 15, 2024
@Ovilia Ovilia mentioned this pull request Jan 25, 2024
Merged
8 tasks
@X-oss-byte X-oss-byte mentioned this pull request May 25, 2024
Open
@chandraguptsharma1 chandraguptsharma1 mentioned this pull request Jul 17, 2024
Open
@Elenore23 Elenore23 mentioned this pull request Jul 20, 2024
Open
@junior junior mentioned this pull request Jul 26, 2024
Closed
@X-oss-byte X-oss-byte mentioned this pull request Aug 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ovilia Ovilia Ovilia approved these changes

Assignees
No one assigned
Labels
PR: author is committer PR: doc unchanged size/XS
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.

[Bug] Binary array data does not work on xaxis but it works on yaxis
2 participants
@linghaoSu @Ovilia